(#25) sysvinit is not a valid service provider on CentOS6

choria-legacy / puppet-nats

NATS.io module for the Choria Orchestrator

http://choria.io

Apache License 2.0

5 stars 16 forks source link

(#25) sysvinit is not a valid service provider on CentOS6 #26

Closed adastidar closed 7 years ago

ripienaar commented 7 years ago

the manifests/install/init.pp needs its class updated
what about redhat 6?
Could you also update the README?
Be great if the commit first line could be (#xx) fixes blah blah
And some failing test here

ripienaar commented 7 years ago

@adastidar still some test fails here :) and a few of the points above valid still too

adastidar commented 7 years ago

@adastidar still some test fails here :) and a few of the points above valid still too

@ripienaar If I remove the default param for Nats::Service_type, the module picks up the correct provider from the hiera defaults but the rspec checks fail.

what about redhat 6?

I dont have a RHEL6 to test this on.

ripienaar commented 7 years ago

@adastidar hmm, maybe leave the default then? honestly I know about zero of puppet testing :)

you can just add the same data file as centos 6 for redhat 6 - same content