choria-legacy / puppet-nats

NATS.io module for the Choria Orchestrator
http://choria.io
Apache License 2.0
5 stars 16 forks source link

Puppet lint, style guide, and spec fixes #31

Closed jeefberkey closed 7 years ago

ripienaar commented 7 years ago

This looks good except the change to single quotes from double :)

jeefberkey commented 7 years ago

I can put them back and add a parameter in .puppet-lint.rc, one minute

ripienaar commented 7 years ago

Kewl. It's easier to stay consistent with doubles throughout than singles. Many other languages are starting to adjust their style guides to favour double quotes and for me the choice is quite deliberate to use them. Appreciate it!

ripienaar commented 7 years ago

looking great, do you mind squashing down to a single commit @jeefberkey ?

jeefberkey commented 7 years ago

@ripienaar np, I'm used to the squash and merge workflow

ripienaar commented 7 years ago

thanks a lot @jeefberkey !