search

choria-plugins / puppet-agent

Choria Plugin capable of managing the Puppet Agent
https://choria.io
Apache License 2.0
1 stars 8 forks source link

puppet_server_address_validator.ddl missing in puppet module choria/mcollective_agent_puppet #26

Closed timdeluxe closed 6 years ago

timdeluxe commented 6 years ago

When we use the module choria/mcollective_agent_puppet in the most current version (2.2.0) from puppet forge, the file files/mcollective/validator/puppet_server_address_validator.ddl is missing, resulting into this error: Error: /Stage[main]/Mcollective_agent_puppet/Mcollective::Module_plugin[mcollective_agent_puppet]/File[/opt/puppetlabs/mcollective/plugins/mcollective/validator/puppet_server_address_validator.ddl]: Could not evaluate: Could not retrieve information from environment XXXXXXXXXX source(s) puppet:///modules/mcollective_agent_puppet/mcollective/validator/puppet_server_address_validator.ddl

We helped ourselves by just copying it there from this repo here. However you might want to fix it in general!?

ripienaar commented 6 years ago

thanks, will check it out!

timdeluxe commented 6 years ago

Update: When downloading the tar.gz archive from forge (https://forge.puppet.com/v3/files/choria-mcollective_agent_puppet-2.2.0.tar.gz) the file is there. Same goes with "puppet module install". When r10k gets the module it is not. I am currently trying to figure out, what gets wrong when r10k is doing its work.

ripienaar commented 6 years ago

that's bizarre, all r10k does is fetch the tgz and expand it :) very weird!

thanks for keeping us up to date

timdeluxe commented 6 years ago

Very strange. The r10k log says it is unpacking that file:

[2018-09-18 13:09:38 - DEBUG2] Valid files unpacked: ["choria-mcollective_agent_puppet-2.2.0", 
... 
"files/mcollective/validator/puppet_server_address_validator.ddl", "choria-mcollective_agent_puppet-2.2.0/files/mcollective/validator/puppet_server_address_validator.rb", 
...
]

...but when looking into that directory it is gone. When i put the module into our local git repo and put that in Puppetfile, the files stay there. Maybe it is a r10k bug?

ripienaar commented 6 years ago

and this file is even in the checksums file, yeah I dont get it, best I can tell this module is doing the right thing:

% puppet module install choria/mcollective_agent_puppet --target `pwd`
Notice: Installing -- do not interrupt ...
/Users/rpienaar/temp
└─┬ choria-mcollective_agent_puppet (v2.2.0)
  └─┬ choria-mcollective (v0.7.0)
    └── puppetlabs-stdlib (v4.25.1)
% find mcollective_agent_puppet -name puppet_server_address_validator.ddl
mcollective_agent_puppet/files/mcollective/validator/puppet_server_address_validator.ddl

not sure this is something i can fix :(

timdeluxe commented 6 years ago

I found out that our production r10k version is quite old (2.1.1). With the current version (2.6.4) it works absolutely fine. Sorry for wrongly disturbing you...

ripienaar commented 6 years ago

No problem at all. What a weird bug!