chorsley / python-Wappalyzer

Python driver for Wappalyzer, a web application detection utility.
GNU General Public License v3.0
309 stars 122 forks source link

AttributeError: 'list' object has no attribute 'split' #53

Closed Maks3w closed 3 years ago

Maks3w commented 3 years ago
self = <Wappalyzer.Wappalyzer.Wappalyzer object at 0x7fe4d83caf70>, pattern = ['Abicart', 'Textalk Webshop']

    def _prepare_pattern(self, pattern):
        """
        Strip out key:value pairs from the pattern and compile the regular
        expression.
        """
        attrs = {}
>       pattern = pattern.split('\\;')
E       AttributeError: 'list' object has no attribute 'split'

/usr/local/lib/python3.8/site-packages/Wappalyzer/Wappalyzer.py:219: AttributeError

Last good wappalyzer commit 842f18aa86faaaf523e9b98e5419e213b40302ca

Broken wappalyzer commit e3bf786826318160f4016b206f5dcd9853c50da0

Broken line https://github.com/AliasIO/wappalyzer/commit/e3bf786826318160f4016b206f5dcd9853c50da0#diff-ad6b5aefcc8c0ba3d7c9f4c9ba096652f7bae1235363a40bba4759f3abb374c4R16897

tristanlatr commented 3 years ago

Hi @Maks3w , Thanks for the report.

So you're saying that it's not normal that the generator contains a list of patterns ? If that's the case I think this issue should be raised in the AliasIO/wappalyzer repository.

The other option is that generator (and other fields) can actually contain a list of patterns, then we should deal with this in our code. It should not be really complicated.

Maks3w commented 3 years ago

WappAlyzer allows a list of patterns. Their JS function allows to parse that

tristanlatr commented 3 years ago

@Maks3w,

This issue should now be fixed!