chorus-ai / chorus_waveform

CHoRUS waveform documentation and various waveform conversion scripts
MIT License
3 stars 3 forks source link

Remove 'post comment' step from benchmark action #109

Closed tompollard closed 1 day ago

tompollard commented 1 day ago

When a pull request comes from a forked repository, the "Post results to pull request" action in the Benchmark.yml workflow fails (e.g. see: https://github.com/chorus-ai/chorus_waveform/pull/105).

The issue is that the GITHUB_TOKEN provided by GitHub Actions only has read permissions. This can be fixed by adding a custom token, but it is quicker and easier to remove the post results step, which is what I am doing here!

The benchmark results should still be posted in the output of the github action, so it's not a big loss.

briangow commented 1 day ago

Thanks @tompollard !