search

chorus-ai / chorus_waveform

CHoRUS waveform documentation and various waveform conversion scripts
MIT License
3 stars 3 forks source link

DICOM Fidelity Check failures #83

Closed tcpan closed 3 months ago

tcpan commented 3 months ago

Previous implementation stored gain * measurements directly, which for some datasets (e.g. Charis8 and Charis9) and some channels (e.g. ABP, ICP) can overflow the value type (e.g. int16).

This pull request changes the encoding to scale the value range to that of the value type. It has yet to be tested against Charis8 and Charis9).

briangow commented 3 months ago

@tcpan , would you be able to separate out the code to fix the fidelity errors from the memory profiler code? As mentioned in https://github.com/chorus-ai/chorus_waveform/pull/80 the memory profiler code is interfering with the read time test, so we don't want to merge that.

tcpan commented 3 months ago

redoing the commit. closing this one.