chouzz / vscode-better-align

Better vertical alignment with/without selection in any language.
https://marketplace.visualstudio.com/items?itemName=Chouzz.vscode-better-align&ssr=false#overview
Apache License 2.0
40 stars 4 forks source link

Attribution for original extension #55

Closed lonix1 closed 1 year ago

lonix1 commented 1 year ago

This is now the recommended replacement for the better-align extension, which is deprecated.

Given that you copied it verbatim, do you not think attribution to https://github.com/WarWithinMe/better-align is warranted? (Otherwise it appears as if this is original work, which is dishonest, and I'm sure that was not your intention.)

Thanks for forking and maintaining this extension, it's very useful.

chouzz commented 1 year ago

This is authorized by the original author. According to https://github.com/microsoft/vscode-discussions/discussions/1#discussioncomment-4155861

lonix1 commented 1 year ago

I was actually referring to attribution - of noting on the main page that this was based/forked from his repo, or having a list of authors which show he was responsible for it up to a certain date, and you took over after that. Otherwise people assume this is original work, which isn't fair to the original author. (Think how you'd feel if someone did that to you...).

But if @WarWithinMe doesn't mind, that's nice (but strange) of him. :smiley:

Anyways, like I said above, this extension is very useful so I'm happy someone took over, and I thank you! :+1:

chouzz commented 1 year ago

OK. I got it. This should be reasonable. I will add attribution in Readme to indicate and thank the original author and his work.

lonix1 commented 1 year ago

You are the man!