Feature download files - Githubissues

chovanecm / sacredboard

Dashboard for sacred. Monitor and access your past machine learning experiments.

MIT License

184 stars 39 forks source link

Feature download files #101

Closed verybadsoldier closed 6 years ago

verybadsoldier commented 6 years ago

Adds viewing and downloading source and artifact files.

Solves #81 and #91

verybadsoldier commented 6 years ago

As a nice to have, the file could have its modification timestamp set correctly, but I think it's fine (unless someone needs it).

Added that in the latest commit. Good point.

My only concern would be whether the file names should really be stored using absolute paths. I had some troubles opening them under Windows (see the double backslash in the path).

Well, I am not entirely happy with it either but I had no good alternative idea yet. One obvious option would be to store all files as a flat structure in the ZIP. Duplicated filenames would have to been handled. Probably like myfile.py and myfile.py (2). But preserving the original directory structure of the files would generally be nice also.

chovanecm commented 6 years ago

1) regarding Python 3.5: I am not sure how long Sacredboard should support it. I am quite happy that there not (that many) people reporting incompatibility with Python 2.7. Maybe it's also time to abandon 3.5 compatibility. I don't have enough data to decide :( 2) regarding paths: It's fine for me with absolute paths but an alternative might be using the experiment's base_dir. But I'm not sure what happens if one of the files were stored outside that base dir. I think we are better off with absolute paths than to mess with such special cases.

chovanecm commented 6 years ago

I will try to work around that failing test_removing_a_run* tests. Something in the testing library must have changed.

verybadsoldier commented 6 years ago

I am currently struggling to get the high score on those Travis checks ;-)

chovanecm commented 6 years ago

I have marked the failing tests to be skipped because the problem is obviously not in Sacredboard.

coveralls commented 6 years ago

Coverage decreased (-2.9%) to 76.522% when pulling 273c4d9be4dd16e9bef49ee5bfa7581240d638a5 on verybadsoldier:feature-download_files into b78c54c04c5e64b76a207c0ab43a1ef4423343db on chovanecm:develop.