Fix #90: runs not displayed using FileStorage when info.json missing.

chovanecm / sacredboard

Dashboard for sacred. Monitor and access your past machine learning experiments.

MIT License

184 stars 39 forks source link

Fix #90: runs not displayed using FileStorage when info.json missing. #103

Closed michalgregor closed 5 years ago

michalgregor commented 5 years ago

Hi, this is a simple proposal to fix issue #90, where no runs are displayed when using the FileStorage backend and info.json files are missing.

coveralls commented 5 years ago

Coverage decreased (-0.1%) to 76.42% when pulling f09433d9d758325991d252e8d50fa43f7a14e317 on michalgregor:develop into b91d1fd1d083b6d54d25def525ef9b9e603f5ab3 on chovanecm:develop.

michalgregor commented 5 years ago

Could someone provide feedback on what these failed checks are about? They do not seem to be related to the changes I proposed, right?

chovanecm commented 5 years ago

Hi, sorry for not responding. I think the travis build failure is not caused by you, it looks like a new rule for coding standards has been enabled; I'll check it hopefully during the weekend. What is "caused" by you is the decreasing code coverage, but I think it is acceptable for such a small fix. Please allow me a few more days to test it on my side before I merge it to the base. Thank you very much for your contribution :)