nus-pe-bot
commented
2 years ago Team's Response
A warning is given to the user in the user guide in the case they choose to edit the JSON data.
We believe that this is a "nice-to-have" feature.
Items for the Tester to Verify
:question: Issue response
Team chose [response.NotInScope]
- [x] I disagree
Reason for disagreement: I do agree with the change to type.FeatureFlaw. However, I would still like to propose that this bug is still within scope. With reference to the PE Guide (second paragraph below):
As mentioned earlier, from the end-user point of view, the omission of this alert box/ prompt for invalid JSON file would most likely result in the user not knowing what went wrong, and the user might even think that the app is buggy or broken when in fact, it is due to the user's own mistake when modifying the data file. Thus, the addition of an alert box when handling such a case would make this feature work in a much better way from the point of view of the end-user (as they would then know the actual cause of being greeted with a 'blank' app, and make the necessary changes to correct the app).
This alert box would also not take much additional effort to implement.
:question: Issue type
Team chose [type.FeatureFlaw]
Originally [type.FunctionalityBug]
- [ ] I disagree
Reason for disagreement: [replace this with your explanation]
When the JSON file is in an invalid format (e.g. overtime hours exceeds 744), upon restarting the application, the application data is cleared without informing the user.
This is what the user immediately sees after restarting the app:
In my opinion, some form of user feedback (e.g. alert box) is necessary to prompt the user that the JSON file is invalid, and that he should recheck the details. Else, the user would not know what went wrong, and might even think that the app is buggy or broken as none of his entries show up.