search

choyiny / afullstop

. <- this is a full stop, not a period
http://pages.choy.in/afullstop/?name=Github
MIT License
4 stars 9 forks source link

Style changes #3

Closed andy-j closed 8 years ago

andy-j commented 8 years ago

Style & indentation consistency changes.

choyiny commented 8 years ago

Thanks, looks good! Can you possibly publish your site to Github Pages so I can preview it before merging? Thanks!

1

andy-j commented 8 years ago

Absolutely!

https://andy-j.github.io/afullstop/

Andy

On Sat, Oct 1, 2016 at 10:39 PM, Yong Cho Yin notifications@github.com wrote:

Thanks, looks good! Can you possibly publish your site to Github Pages so I can preview it before merging? Thanks!

1 https://github.com/choyiny/afullstop/issues/1

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/choyiny/afullstop/pull/3#issuecomment-250953287, or mute the thread https://github.com/notifications/unsubscribe-auth/ABR7nWil2JF2cTmV4IXuf1oUwJsuxG3nks5qvzWBgaJpZM4KL7nm .

choyiny commented 8 years ago

It would be great if you could introduce new UI changes to the webpage. Also, can you create a new html file for your page? I'm getting merge conflicts.

andy-j commented 8 years ago

Merge conflicts should just be spacing & indentation - I added in the animate.css reference and all of the text is the same.

choyiny commented 8 years ago

There are still merge conflicts, can you create a new page under /pages/ ?

choyiny commented 8 years ago

Do you still intend to work on this PR? @andy-j

choyiny commented 8 years ago

Closed.