search

chpill / re-frankenstein

The deviant fork of re-frame
MIT License
36 stars 1 forks source link

More stateful effects to override #2

Open chpill opened 7 years ago

chpill commented 7 years ago

While looking at #1, I also noticed a problem with the effects that are registered in https://github.com/Day8/re-frame/blob/cf61b2db1da360687c6b247888b29fb58bedf7cb/src/re_frame/fx.cljc

:dispatch :dispatch-later and :dispatch-n all use the global dispatch. :deregister-event-handler uses the global registry.

So we will also need to swap them with "local" version when we instanciate a frank...

The solution here will depend on what comes out of #1

chpill commented 7 years ago

https://github.com/chpill/re-frankenstein/commit/c3e28389c840305f1a4686628e1a19c111e08689