search

chr15m / bugout

Back end web app services over WebRTC.
https://chr15m.github.io/bugout
MIT License
604 stars 59 forks source link

Fix messageboard example iOS PWA support #54

Closed hello-smile6 closed 2 years ago

hello-smile6 commented 2 years ago

<meta name="apple-mobile-web-app-capable"> is for iOS. <meta name="mobile-web-app-capable"> is for Android.

chr15m commented 2 years ago

@hello-smile6 are you sure this is required? I thought Apple devices respected both versions? If you can verify it definitely fails on iOS I'm happy for this to be merged.

hello-smile6 commented 2 years ago

@hello-smile6 are you sure this is required? I thought Apple devices respected both versions? If you can verify it definitely fails on iOS I'm happy for this to be merged.

I verified it over a year ago. Also, https://developer.apple.com/library/archive/documentation/AppleApplications/Reference/SafariHTMLRef/Articles/MetaTags.html#:~:text=%3Cmeta%20name%3D%22apple%2Dmobile%2Dweb%2Dapp%2Dcapable%22%20content%3D%22yes%22%3E supports it. If the <meta> tag for iOS is not included, install fails. Related: RobinLinus/snapdrop#238

chr15m commented 2 years ago

Ok, maybe it's the other way around and Android devices honour the Apple specific one. Happy to merge this if you are @draeder.

draeder commented 2 years ago

It looks like Chrome for Android has supported this for some time, so I don't see any issues with it.

hello-smile6 commented 2 years ago

Ok, maybe it's the other way around and Android devices honour the Apple specific one. Happy to merge this if you are @draeder.

As far as I'm aware, you have to use both for it to work on both platforms.

draeder commented 2 years ago

@hello-smile6 I just tested this on IOS 14.8 / iPhone 12 and it seems to be working fine. Could you provide some more detail about what you mean when you say 'install fails'? I assume you mean you're trying to use the message board demo code as a basis for a PWA app. Is that correct?

hello-smile6 commented 2 years ago

@hello-smile6 I just tested this on IOS 14.8 / iPhone 12 and it seems to be working fine. Could you provide some more detail about what you mean when you say 'install fails'? I assume you mean you're trying to use the message board demo code as a basis for a PWA app. Is that correct?

It doesn't work without that tag on iOS 12, which is still quite popular.

draeder commented 2 years ago

@chr15m I don't have a good way to test this, otherwise I would merge the PR. It doesn't appear to be a change that would break anything, but I can't be certain without testing. I'm going to defer to your wisdom on this.

chr15m commented 2 years ago

I don't see a huge need for it since it's a demo page but I also don't see any great problem with merging it. :shrug: