search

chr15m / bugout

Back end web app services over WebRTC.
https://chr15m.github.io/bugout
MIT License
603 stars 59 forks source link

catch lib crash when call rpc without args closes #63 #67

Closed Kos-M closed 1 year ago

Kos-M commented 1 year ago

closes #63

Prefered args to left null (as it is in catch block) instead of an empty object , because that leads to another crashing in another line ( if a recall corectly , in a JSON.parse line )

Kos-M commented 1 year ago

Simplified checks , as you suggested ( better that way) . Tests for this case , all pass. Not related on this , some tests fails , some with errors in plan ( not correct statement of total assertions , i think ) and some others with message like : not ok 63 bTwbdRC1EQxxkwY9vMr2dRRbPAZNWp2Rzh left unexpectedly They are not related with my changes , as i noticed before start working on this. Maybe should open another issue for them..

Kos-M commented 1 year ago

Any update on this @chr15m ? Do you need any other change ? (:

chr15m commented 1 year ago

I'm on the road but will try to review & merge soon.

Kos-M commented 1 year ago

Sure , just checking if i was missing somthing , drive safe!

Kos-M commented 1 year ago

ready :+1:

chr15m commented 1 year ago

Thanks for this fix and for your patience.

Kos-M commented 1 year ago

My pleasure @chr15m :smile: