Fix ByteRate always being zero

chr15m / jsfxr

JavaScript sound effects generator.

http://sfxr.me

The Unlicense

271 stars 25 forks source link

Fix ByteRate always being zero #6

Closed rparrett closed 3 years ago

rparrett commented 3 years ago

jsfxr is currently outputting slightly invalid wav files due a typo in riffwav.js. This PR fixes that.

Most audio tools seem to read them just fine, but I'm over here because they don't currently work in the bevy game engine, which ultimately depends on hound to do wav decoding.

rparrett commented 3 years ago

I also attempted to report this "upstream" here: https://gist.github.com/hackNightly/3776503#gistcomment-3879853

But I have no idea if that's even the right place to go for that.

chr15m commented 3 years ago

Thanks so much!