search

chr15m / jsfxr

JavaScript sound effects generator.
http://sfxr.me
The Unlicense
271 stars 25 forks source link

Middle section gets too wide and wiggles around sometimes #7

Closed grumdrig closed 2 years ago

grumdrig commented 2 years ago

You've done some great things with this project, so thanks for improving it. My one quibble is that when the Frequency Delta Slide gets too wide (too close to zero) it moves that whole section around. For some reason the numbers in my version of the app don't get so small (and therefore large because of all the leading zeros.)

Maybe it would help to change the relevant function:

p_freq_dramp: function (v) {
    return (v*44100 / Math.pow(2, -44101./44100)).toPrecision(4) +
' 8va/sec^2?'; },

by multiplying it by 1000 and expressing the units as m8va/sec^2?

And/or boldly remove the question mark?

And/or changing sec^2 to sec<sup>2</sup>? But that might cause other layout difficulties.

chr15m commented 2 years ago

Huh, I hadn't noticed that before. Thanks for the suggestions, will try them out.

Erik thanks so much for making and releasing jsfxr under a permissive license. I've had a lot of fun making weird things with it over the years like this chiptune live-coding IDE and this album and I recently started working on a chiptune tracker that uses it too. Very grateful! I never would have had the patience to implement this myself. :pray:

grumdrig commented 2 years ago

Wow, that's a lot of great stuff. It looks like you have plenty of patience. And all props have to go to Dr. Petter for the brilliant original.

On Sun, Nov 14, 2021 at 12:52 AM Chris McCormick @.***> wrote:

Huh, I hadn't noticed that before. Thanks for the suggestions, will try them out.

Erik thanks so much for making and releasing jsfxr under a permissive license. I've had a lot of fun making weird things with it over the years like this chiptune live-coding IDE https://chr15m.github.io/speccy/ and this album https://chr15m.bandcamp.com/album/hacksilver and I recently started working on a chiptune tracker https://8bitmusicmaker.com that uses it too. Very grateful! I never would have had the patience to implement this myself. 🙏

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/chr15m/jsfxr/issues/7#issuecomment-968249567, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABKVXJJ4OYIGS2W46UHAF3UL52FJANCNFSM5H7FMG4Q . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

chr15m commented 2 years ago

Wow it took me forever to figure out how to fix that wiggle!

grumdrig commented 2 years ago

Looks great, though. Thanks!

On Fri, Dec 31, 2021 at 8:17 PM Chris McCormick @.***> wrote:

Wow it took me forever to figure out how to fix that wiggle!

— Reply to this email directly, view it on GitHub https://github.com/chr15m/jsfxr/issues/7#issuecomment-1003502186, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABKVXOJ6FFSYQD6IHUM44LUTZ55XANCNFSM5H7FMG4Q . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you authored the thread.Message ID: @.***>