Potential libpng, visualization issues and Segmentation fault: 11 for flapper/flappers/multi-drop examples

[erizmr]

Hi Chris, Thanks for sharing your amazing codes! I have tried to compile and run examples in ./ftest. It works well and fast in most cases. Here are some issues I met on Mac OS Catalina 10.15.6, all required dependencies were installed via Homebrew

• Potential libpng issue This occurs when complete for the utils-gp library. And I check the libpng with Homebrew, it did have been installed on my machine. So I comment the png_lflags in the config.mk file to disable libpng for a temporal solution and it works. I am wondering if there are any suggestions for this if would like to install libpng for full functionality?

• Visualization I tried ./gnuplot_movie.pl -t xxx.odr w -10 10 and got images (left below) quite similar to those in the paper(right below) but without mesh on solid objects.

  

And the ./gnuplot_movie.pl complains about something during the output process. Did I miss something to compile for the ../../shared/make_contour?

• Segmentation fault: 11 for flapper/flappers/multi-drop examples I test all the available examples in the ./fest. A Segmentation fault: 11 occurs when execute flapper/flappers examples after parameters initilization as shown below. (For multi-drop, the error occurs even before the parameters initilization) Do you have any clues about it?

  

• Some other minor potential issues:

  1. Got gp_palette.hh:28:29: error: 'FILE' has not been declared. Sorted after adding #include<stdio.h> in gp_palette.hh.
  2. A typo in Readme Example part: OMP_NUM_THREADS=4 ./ftest simple_spin 128 might be OMP_NUM_THREADS=4 ./ftest simple-spin 128

Looking forward to your reply. Thanks.

[chr1shr]

Hi Mingrui,

Thanks for your interest in these codes and for pointing out these issues. It's good to have someone else look over this!

• I think I've fixed the Homebrew configuration issue. I think it requires specifying /usr/local/include as an additional directory for searching for headers, and /usr/local/lib as an additional directory for searching for libraries.

• I've fixed the path for the gnuplot_movie.pl script. If you have the three repos, utils-gp, tgmg, and incrmt, in a common parent directory (as discussed in the documentation) then it should find the make_contour utility now.

• I've fixed the segfault for the flapper/flappers example. Just before I uploaded the code to GitHub, I did some cleanups to the object classes. I realized that I made a small error in the obj_flapper class, where a pointer was duplicated.

• I've fixed the missing header in gp_palette.hh, although I used cstdio instead of stdio.h, since the former is more appropriate for C++.

• I've fixed the typo in the simple-spin README example.

Chris.

[erizmr]

Hi Chris,

Thanks for your detailed reply! I think now the issues have been well sorted.

Mingrui