Closed pmla closed 2 years ago
Thanks for adding this functionality. I have approved this merge.
We are currently working on a development version of the library, and I will ensure the solid_angles
function is added to this version although I may revise the implementation then. Two small comments:
norm
is zero. There are reasonable situations where that could happen, such as when walls have cut a Voronoi cell such that one of the vertices lies at the particle position. Perhaps solid angles aren't relevant but it might be good for the routine to have some way to handle this.
In this PR I have implemented solid angle calculation for Voronoi cell faces.
Quite a few downstream projects use Voro++ to calculate these. It would be very convenient and save a lot of duplication to have this functionality in Voro++ itself.