chr1shr / voro

Voro++: a three-dimensional Voronoi cell library in C++
Other
154 stars 44 forks source link

ENH: calculate solid angles of Voronoi cell faces #21

Closed pmla closed 2 years ago

pmla commented 2 years ago

In this PR I have implemented solid angle calculation for Voronoi cell faces.

Quite a few downstream projects use Voro++ to calculate these. It would be very convenient and save a lot of duplication to have this functionality in Voro++ itself.

chr1shr commented 2 years ago

Thanks for adding this functionality. I have approved this merge.

We are currently working on a development version of the library, and I will ensure the solid_angles function is added to this version although I may revise the implementation then. Two small comments: