search

chr1swallace / coloc

Repo for the R package coloc
144 stars 44 forks source link

Moves testing (including R cmd check) to github actions #70

Closed pc494 closed 1 year ago

pc494 commented 2 years ago

Sorry about the false PR, I'm now happy with where this is and this is a 'true' PR.

This PR removes thetravis.yml and instead implements testing using github actions. I've had good experiences with this technology in the past, and it seems well supported by the R community at large.

The "testing" involves running R cmd check against the code on all three major operating systems, with R version "current" and "development" (at time of writing 4.1.5 and 4.2.0). The CI will also run the code in the testthat folder which may encourage users to write more tests (because they can know that they will get run!)

This implementation is broadly as described here and was produced using the R command use_github_action_check_standard as described here. I then manually tweaked the .yaml file to give suitable version testing (broadly to answer, "does it work now?" and "will it work when I submit to CRAN" (who check against development versions of R).

I also fixed a small import bug that caused the suite to fail (7dc129213cea13b19a02e56325fb3514d2f921c5)

pc494 commented 2 years ago

I have updated this workflow so that the testing now only runs on pull requests to main. You can see this in action in https://github.com/pc494/coloc/pull/7 - the motivation for this is that fixing small typos in main doesn't need CI, and we can thus save resources by not doing it.

As only owners can commit directly to main this means all user contributions will have to pass the suite.