Deprecate runsusie() arg p

chr1swallace / coloc

Repo for the R package coloc

139 stars 44 forks source link

Deprecate runsusie() arg p #78

Closed jdblischak closed 2 years ago

jdblischak commented 2 years ago

This PR is a follow-up to Issue #77

Removes documentation about runsusie() argument p
Sends a warning if a user sets p to a non-NULL value (previously this would silently have no effect)
Adds some tests related to p and null_weight

I regenerated the pkgdown site locally, but that created a lot of noise, so I didn't include those changes. If you'd like me to rebuild the entire site, please just me let me know.

jdblischak commented 2 years ago

R CMD check ran successfully locally and also for the Travis build on my fork. The only issue is the known warning about utils::packageVersion() that has already been addressed in PR #70

chr1swallace commented 2 years ago

thank you for taking the time to make a PR, very helpful!