chr233 / ASFEnhance

ASF 扩展命令插件 / External commands for ASF
GNU Affero General Public License v3.0
497 stars 41 forks source link

Add a new command #113

Open 1UNKNOWNAME3 opened 1 year ago

1UNKNOWNAME3 commented 1 year ago

Please add a command to increase the level of the "Owned Games"(+1) badge image

chr233 commented 1 year ago

maybe use steamDB is better https://steamdb.info/freepackages/

woctezuma commented 1 year ago

Ah, I understand it now: the user asks for a command which would add all the "No Cost" packages as listed in this Steam guide.

I don't think it is a good idea to support this feature as:

woctezuma commented 1 year ago

It is a pain that the user posted a picture instead of pasting the table as text in their question. However, I went through the list and it proves my point:

sub/33694 | Statut : AccessDenied/InvalidPackage
sub/35063 | Statut : OK/NoDetail (but no increment of the game counter)
sub/50861 | Statut : OK/NoDetail (but no increment of the game counter)
sub/60341 | Statut : Fail/DoesNotOwnRequiredApp
sub/69802 | Statut : OK/NoDetail (but no increment of the game counter)
sub/81026 | Statut : Fail/DoesNotOwnRequiredApp

For the two DLC which require the base game, I can do:

!addlicense ASF 69802,60341
sub/69802 | Statut : Fail/AlreadyPurchased (the list order matters and is wrong in the first post)
sub/60341 | Statut : OK/NoDetail (but no increment of the game counter)
!addlicense ASF 72261,81026 
sub/72261 | Statut : OK/NoDetail (but no increment of the game counter)
sub/81026 | Statut : OK/NoDetail (but no increment of the game counter)

This show how cumbersome it is to keep track of the correct list of packages:

  1. the original poster misses 5 packages from the 24 ones in the guide, which means the recall is only 19/24 ~ 79%,
  2. the original poster listed 6 invalid packages among the 25 listed ones, which means the precision is only 19/25 ~ 76%,
    • either impossible to activate nowadays as for Grimm,
    • or which are DLC and thus do not increment the game counter,
  3. if the original poster were interested in DLC, then the order of package activations matters, and they got it wrong anyway.
1UNKNOWNAME3 commented 1 year ago

maybe use steamDB is better https://steamdb.info/freepackages/

that's not what I meant... you threw off the link to the distribution of games, and I wrote about those games that are always free and give +1 to the badge https://steamcommunity.com/groups/vrachievementhunters/discussions/2/1697168437872583585/

chr233 commented 1 year ago

I see, but these features can use original ASF command to reach the goal

Enissay commented 1 year ago

As @chr233 said, this already included in the basic ASF functionalities!

For the games that are free currently (your list), you can test adding them one by one on a single bot until you find the correct codes (it needs some work, but if you cannot, you can still ask in reddit, see next), then apply all at once on all bots (comma separated codes). Then for the new free ones, keep an eye on r/FreeGamesOnSteam, the community there share new free games and in comment they add the correct ASF code for it!