REMOVEDEMOS removes FreeOnDemand packages which are not demos

woctezuma commented 1 year ago

It seems the !REMOVEDEMOS command removes FreeOnDemand packages which do not belong to the Demo category.

I believe the filter must be based on the package name, but I am not sure as I have not dived into the code.

Indeed, these two packages are actually both named Tactical Monsters - Strategy Edition Demo:

sub/623611 Tactical Monsters - Strategy Edition Demo ➡️ app/1739920 App Type: Demo
sub/619516 Tactical Monsters - Strategy Edition Demo ➡️ app/1729830 App Type: Game

And it seems that the !REMOVEDEMOS command has removed both packages.

If this is the case, it may be useful to:

check that the App Type is Demo before removing the package,
otherwise, mention in the README that the filter is based on package names, and thus imperfect.

Edit: Confirmed. There is a check for x.Name.EndsWith("Demo") in:

x.Type == LicenseType.Complimentary && x.Name.EndsWith("Demo")

Reference:

So the command catches FreeOnDemand packages:

chr233 commented 1 year ago

Got it

LORDIF56 commented 11 months ago

update pls to NET 8.0 global version ASF now use 8.0 and creat conflict if we start ASF and if we have ASFEnchance

woctezuma commented 11 months ago

update pls to NET 8.0 global version ASF now use 8.0 and creat conflict if we start ASF and if we have ASFEnchance

You have posted about an issue which was fixed 3 weeks ago, and in the wrong thread on top of that:

woctezuma commented 4 months ago

I suggest to remove this feature. Indeed:

the feature does not work as expected, because it filters by name instead of by type, which leads to catching false positives,
demos are automatically and regularly removed by Steam nowadays:
- https://github.com/Citrinate/FreePackages/issues/44

chr233 commented 4 months ago

yep

chr233 / ASFEnhance