chr233 / ASFEnhance

ASF 扩展命令插件 / External commands for ASF
GNU Affero General Public License v3.0
489 stars 40 forks source link

!VOTE only works for the first bot #167

Closed woctezuma closed 9 months ago

woctezuma commented 9 months ago

I have tried to vote for the 11 nominations:

!vote ASF 1868140,2296380,531640,1997040,1260320,1977170,1624540,1976950,1817230,1976950,2225070

I can see that the appIDs are correctly understood for the first bot. However, the command only works for the first bot!

>> !vote ASF 1868140,2296380,531640,1997040,1260320,1977170,1624540,1976950,1817230,1976950,2225070

<MainBot> Nominate at least 1 game: √
Nominate a game in each category: √
Play a game you nominated: √
Review or update your review of a game you nominated: √
>> !checkvote ASF

<MainBot> Nominate at least 1 game: √
Nominate a game in each category: √
Play a game you nominated: √
Review or update your review of a game you nominated: √

<AltBot1> Nominate at least 1 game: ×
Nominate a game in each category: ×
Play a game you nominated: ×
Review or update your review of a game you nominated: ×

<AltBot2> Nominate at least 1 game: ×
Nominate a game in each category: ×
Play a game you nominated: ×
Review or update your review of a game you nominated: ×

<AltBot3> Nominate at least 1 game: ×
Nominate a game in each category: ×
Play a game you nominated: ×
Review or update your review of a game you nominated: ×
Botan626 commented 9 months ago

and it doesn't vote in these categories: image image

chr233 commented 9 months ago

maybe reach the steam network limits, thinking for a better solution

bolexator commented 9 months ago

maybe reach the steam network limits, thinking for a better solution

I and others have the same problems. Regardless of network, regardless of country. Nominations are the same everywhere. It doesn't seem to be a problem with the stim network.

woctezuma commented 9 months ago

I believe the votes are only cast for the first bot.

Indeed, even if I ask to cast the votes for a single other bot, e.g. AltBot2, I get the output for the MainBot.

>> !vote AltBot2 1868140,2296380,531640,1997040,1260320,1977170,1624540,1976950,1817230,1976950,2225070

<MainBot> Nominate at least 1 game: √
Nominate a game in each category: √
Play a game you nominated: √
Review or update your review of a game you nominated: √
woctezuma commented 9 months ago

and it doesn't vote in these categories: image image

Maybe due to the hard-limit of 10. There are 11 categories, but there is a check for 10 appIDs. 🤔

https://github.com/chr233/ASFEnhance/blob/2de1e5c5f79d4b8173cc1be6a076e4e3c33644e7/ASFEnhance/Event/Command.cs#L378-L388 https://github.com/chr233/ASFEnhance/blob/2de1e5c5f79d4b8173cc1be6a076e4e3c33644e7/ASFEnhance/Event/Command.cs#L390-L397

pontifezo commented 9 months ago

Plugin votes only in 10 categories, but 11th category "Sit Back and Relax Award" is not voted.

reanoff commented 9 months ago

ASFEnhance 2.0.1.1 Pre-release

woctezuma commented 9 months ago

It looks like the fix is in Rudokhvist/ASFEnhance/tree/eventfix. Meanwhile, I will try the new version (2.0.1.1).

woctezuma commented 9 months ago

The issue is not fixed in the new version. I think the fix is probably in:

Picture

reanoff commented 9 months ago

Voting does not remain in every category.

woctezuma commented 9 months ago

Voting does not remain in every category.

See https://github.com/chr233/ASFEnhance/pull/168#issuecomment-1823046564

woctezuma commented 9 months ago

Fixed with https://github.com/chr233/ASFEnhance/releases/tag/2.0.1.1.

reanoff commented 9 months ago

Fixed with https://github.com/chr233/ASFEnhance/releases/tag/2.0.1.1.

no

reanoff commented 9 months ago

!vote 01 1868140,2296380,440,1997040,1260320,1977170,1624540,1976950,1817230,1976950,2108330 <

<01> Nominate at least 1 game: √ Nominate a game in each category: × Play a game you nominated: × Review or update your review of a game you nominated: × > !vote 01 1868140,2296380,531640,1997040,1260320,1977170,1624540,1976950,1817230,2225070 < <01> Nominate at least 1 game: √ Nominate a game in each category: × Play a game you nominated: × Review or update your review of a game you nominated: × > !vote 01 1868140,2296380,440,531640,1997040,1260320,1977170,1624540,1976950,1817230,2225070 < <01> Nominate at least 1 game: √ Nominate a game in each category: × Play a game you nominated: × Review or update your review of a game you nominated: × > !vote 91 1868140,2296380,440,531640,1997040,1260320,1977170,1624540,1976950,1817230,2225070 < <91> Nominate at least 1 game: √ Nominate a game in each category: × Play a game you nominated: × Review or update your review of a game you nominated: × > !vote 91 1868140,2296380,531640,1997040,1260320,1977170,1624540,1976950,1817230,1976950,2225070 < <91> Nominate at least 1 game: √ Nominate a game in each category: × Play a game you nominated: × Review or update your review of a game you nominated: ×
woctezuma commented 9 months ago

The issue with the first bot was fixed, but not the rest, hence why I closed this issue.