chr233 / ASFEnhance

ASF 扩展命令插件 / External commands for ASF
GNU Affero General Public License v3.0
489 stars 40 forks source link

EXPLORER #195

Closed qirieshkaclwn closed 5 months ago

qirieshkaclwn commented 8 months ago
qirieshkaclwn commented 8 months ago

i am retard

d1ret commented 8 months ago

Ты пофиксил это?

Я так понял при юзании эксплорера у тебя тоже не забирает карты? Но при этом если зайти вручную на акк ,то карта даётся?

reanoff commented 8 months ago

It doesn't collect from me

woctezuma commented 8 months ago

It works fine for me on unlimited bot accounts.

Make sure the cards have not been automatically forwarded to your main account before you noticed.

reanoff commented 8 months ago

У меня это отлично работает с неограниченным количеством учетных записей ботов.

Убедитесь, что карты не были автоматически перенаправлены на ваш основной аккаунт до того, как вы заметили.

does not work

reanoff commented 8 months ago
Explore discovery queue task will start immediately But the cards don't fall out
reanoff commented 8 months ago

When manually, the card will drop out image

d1ret commented 8 months ago

same

chr233 commented 8 months ago

see ASF's manual https://github.com/JustArchiNET/ArchiSteamFarm/wiki/Configuration#autosteamsaleevent

what this command actually do is reset the ASF's timer.

CrazyGhostRider commented 8 months ago

Yes. Does not work.

Unriot commented 8 months ago

same, whats gonna be wrong?

woctezuma commented 8 months ago

Do you guys use the latest version of ASF?

Unriot commented 8 months ago

Do you guys use the latest version of ASF?

yeah sure:

ASFEnhance 2.0.6.0 MobileAuthenticatorPlugin 5.5.0.11 ASF Achievemenevement Manager Ex 1.0.2.0 ItemsMatcherPlugin 5.5.0.11 SteamTokenDumperPlugin 5.5.0.11

image

but still no card

chr233 commented 8 months ago

This bug has a low priority, and I have to do more important work, it will be slow to fix it.

qirieshkaclwn commented 8 months ago

у меня была проблема в другом и я её пофиксил но сейчас у меня image

qirieshkaclwn commented 8 months ago

пишет что 0 но если собрать вручную то пишет -1 в стим Come back tomorrow to earn another card by browsing your Discovery Queue! на всех аккаунтах

qirieshkaclwn commented 8 months ago

@chr233 can you make a version of the plugin without checking if the card is available?

chr233 commented 8 months ago

@chr233 can you make a version of the plugin without checking if the card is available?

not understand what u want, can u explain more?

d1ret commented 8 months ago

@chr233 can you make a version of the plugin without checking if the card is available?

Как отметил chr23 - команда всего лишь сбрасывает таймер, на который ориентируется ASF. А значит, это проверку нужно убирать в самом ASF

chr233 commented 8 months ago

what asfenhance do is reset the ASF's timer, the core logic is in the ASF, I cant do that

qirieshkaclwn commented 8 months ago

steam says "Today you can get 0 more cards if you continue to view the list of recommendations." if I register EXPLORER ASF I'll see it in the console "Come back tomorrow to earn another card by browsing your Discovery Queue!" but if you collect it manually, steam will write "Today you can get -1 more cards if you continue to view the list of recommendations." and will issue a card

qirieshkaclwn commented 8 months ago

can you remove the check that leads us to "Come back tomorrow and get another card by looking at your discovery queue!"

woctezuma commented 8 months ago

Today you can get -1 more cards

The -1 is a bit weird, no? Maybe it is part of the issue?

cf. https://github.com/chr233/ASFEnhance/issues/195#issuecomment-1868247945

Picture

cf. https://github.com/chr233/ASFEnhance/issues/195#issuecomment-1868442390

Picture

darkdroider commented 8 months ago

Same error here.

d1ret commented 8 months ago

I fixed it in ASF SteamSaleEvent.cs code :)

Is this happening because ASF first checks if the sale card is available?

If so, a new recommendation list is generated.

To fix this, I cut out the code to make ASF send a request to generate a new recommendation list.

woctezuma commented 8 months ago

Is this happening because ASF first checks if the sale card is available?

I see. So the issue stems from the negative number of cards available returned by Steam.

Igorelysss commented 8 months ago

This line checks whether the discovery queue is available? private async Task<bool?> IsDiscoveryQueueAvailable()

d1ret commented 8 months ago

This line checks whether the discovery queue is available? private async Task<bool?> IsDiscoveryQueueAvailable()

Yes. But I just cut the function call out of "for"

Was:

for (byte i = 0; (i < MaxSingleQueuesDaily) && Bot.IsConnectedAndLoggedOn && (await IsDiscoveryQueueAvailable().ConfigureAwait(false)).GetValueOrDefault(); i++)

became:

for (byte i = 0; (i < MaxSingleQueuesDaily) && Bot.IsConnectedAndLoggedOn; i++)

Igorelysss commented 8 months ago

Thanks

chr233 commented 7 months ago

honestly, this works fine in my environment