python cookbook dependency

chr4-cookbooks / duplicity_ng

Chef cookbook to install duplicity and manage duplicity backup cronjobs

Other

3 stars 5 forks source link

python cookbook dependency #43

Closed rmoriz closed 7 years ago

rmoriz commented 7 years ago

the python cookbook is deprecated for some years and throws deprecation warnings that it will fail with chef13 (which will be released on April 10th).

https://supermarket.chef.io/cookbooks/python

Probably the way to go: migrate to https://supermarket.chef.io/cookbooks/poise-python

see https://github.com/poise/poise-python#upgrading-from-the-python-cookbook

chr4 commented 7 years ago

Thanks for the info!

Mmh, another option would be to drop pip support from the cookbook. I think @merqlove added support for pip and the python dependency back then. Can you comment on this? Is the python support still required?

merqlove commented 7 years ago

Hi, seems that it can work from sources instead.

Best regards, Alexander Merkulov

5 апр. 2017 г., в 18:13, Chris Aumann notifications@github.com написал(а):

Thanks for the info!

Mmh, another option would be to drop pip support from the cookbook. I think @merqlove added support for pip and the python dependency back then. Can you comment on this? Is the python support still required?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

rmoriz commented 7 years ago

Other issues:

kitchen: oudated bento boxes were removed from atlas
minitest: broken, hangs also depcrecated by chef for some years for serverspec, now deprecated for chefs own "inspec" framework
poise-python: it seems that it cannot install pip from local .tar.gz file which breaks the GnuPGInterface package. (investigation)

chr4 commented 7 years ago

Thank you for looking into this! As far as I'm concerned, we can drop the pip and python support completely. All servers I'm operating are recent enough to provide adequate packages.

rmoriz commented 7 years ago

Okay, I'll do some refactorings and aim for a new major release, are you okay with that?

chr4 commented 7 years ago

That would be awesome! If it's something big, try splitting it up into smaller pull-requests or commit early. That makes reviewing a little easier.

Suggestions:

[ ] Replace rubocop with cookstyle

rmoriz commented 7 years ago

I tried it but too much is broken. Minitest handler is already broken with chef12, many kitchen targets are not on atlas anymore, Gemfile.lock is not there, nor chefdk...

Von meinem iPhone gesendet

Am 19.04.2017 um 11:42 schrieb Chris Aumann notifications@github.com:

That would be awesome! If it's something big, try splitting it up into smaller pull-requests or commit early. That makes reviewing a little easier.

Suggestions:

Replace rubocop with cookstyle — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

gsreynolds commented 7 years ago

Hi! Noticed this issue and just wanted to contribute the changes in #45 for moving the pip install to poise-python if you wanted to keep that in the cookbook. Converges successfully under install-source-pip-debian-87, install-source-pip-centos-73 and install-source-pip-ubuntu-1604 (not tested the others but presumably work too)

chr4 commented 7 years ago

Closing this in favor of https://github.com/chr4-cookbooks/duplicity_ng/pull/45