chr4-cookbooks / duplicity_ng

Chef cookbook to install duplicity and manage duplicity backup cronjobs
Other
3 stars 5 forks source link

Use poise-python cookbook #45

Closed gsreynolds closed 7 years ago

gsreynolds commented 7 years ago

Hi! Noticed #43 and just wanted to contribute poise-python based duplicity install we already had in our duplicity wrapper cookbook. Hope it helps!

rmoriz commented 7 years ago

Does the combination of package + pip addons work on centos?

gsreynolds commented 7 years ago

Thanks, happy to help out. I'll remove the comments and verify pip add-ons tomorrow.

Chef has supported multipackage installs since 12.1 which was released 2 years ago, I thought it might be safe enough to swap over to the new syntax. See https://docs.chef.io/resource_package.html#multiple-packages and https://blog.chef.io/2015/03/03/phil-dibowitz-chef-client-12-1-0-multipackage-installs/. If you prefer, I think either the compat_resource or multipackage cookbooks provide compat back to to 12.0. On Thu, 20 Apr 2017 at 18:00, Roland Moriz notifications@github.com wrote:

Does the combination of package + pip addons work on centos?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/chr4-cookbooks/duplicity_ng/pull/45#issuecomment-295814618, or mute the thread https://github.com/notifications/unsubscribe-auth/ABdmeriLZx5TQeK4IUucItInB_HIjLORks5rx48ggaJpZM4NDO3L .

gsreynolds commented 7 years ago

Hi, updated the PR now to address the requested changes. Verified as working under package + addons, source + addons and source with pip + pip addons for centos and debian.

Also added an install_par2 recipe for the Par2 Wrapper Backend which we are using par2+scheme://[user[:password]@]host[:port]/[/]path

The only issues I can see, not related to this PR, are that the python-gnupginterface package doesn't exist in debian > 7. (https://packages.debian.org/search?keywords=python-gnupginterface) and python-swiftclientcan't be found under centos 7.

* No candidate version available for python-swiftclient
           ================================================================================
           Error executing action `install` on resource 'yum_package[python-swiftclient]'
           ================================================================================

Let me know what you want to do about the multipackage install syntax.

gsreynolds commented 7 years ago

Does the combination of package + pip addons work on centos?

Oops, just realised what you meant. Pushed a commit with another suite package-pip to cover this combination.

gsreynolds commented 7 years ago

Thanks for approving @chr4 :+1:

chr4 commented 7 years ago

LGTM, merging. Thanks for the contribution! Mind being added to the contributors list in the README?

gsreynolds commented 7 years ago

Don't mind at all, happy for my name and email on my profile to be listed.

chr4 commented 7 years ago

Ok. Added you to the list of contributors, and released 2.0.0 on the Supermarket. I've chosen a major release for this. Thanks again!