search

chr4-cookbooks / iptables-ng

Cookbook to maintain iptables rules and policies on different platforms, respecting the way the os handles these settings.
GNU General Public License v3.0
38 stars 33 forks source link

WIP: Build rules from resource_collection #48

Closed nathwill closed 8 years ago

nathwill commented 9 years ago

still a lot of work to do before i'm ready to call this good to merge, but figured i'd open a PR sooner rather than later, as the change-set's pretty big, and i want to give you a chance to look it over and provide early feedback.

fundamentally, this addresses the issue with rules that have been removed from the run list continuing to be applied due to file globbing, but there's some other changes i'll explain/justify in greater detail when i've got some time to circle back on this a bit more.

immediate priority is to do additional build-out on unit/integration testing, then a bit of tidy up/DRY-ification, but the general concepts are pretty well developed and functional at this point.

chr4 commented 9 years ago

Wow, this indeed seems to be something major! If you don't mind, you can split up some cases (like updating kitchen boxes, improving travis and other changes) into small pull requests that we can merge beforehand.

nathwill commented 9 years ago

yep, can do! expect to see this coming in smaller chunks over the next week of so :+1:

nathwill commented 9 years ago

alright, got a smaller PR focused on the dev workflow updates submitted https://github.com/chr4-cookbooks/iptables-ng/pull/49.