search

chr4-cookbooks / iptables-ng

Cookbook to maintain iptables rules and policies on different platforms, respecting the way the os handles these settings.
GNU General Public License v3.0
38 stars 33 forks source link

Fix issue with fatal error updating the chain file content #62

Closed andytson closed 7 years ago

andytson commented 7 years ago

Resources don't have property methods, but have single methods that set/get the value

chr4 commented 7 years ago

Thanks for spotting the issue and the pull-request!

I've encountered this error on a system with an ancient chef-client, but assumed this was a compatibility issue. Which version of chef-client are you encountering the issue with? Does the change affect recent chef-client versions?

andytson-inviqa commented 7 years ago

This was chef 12.10.24

andytson-inviqa commented 7 years ago

Sorry, I've tracked it back to the source chef version that added the property method way, and see https://github.com/chef/chef/commit/c7f314f08d8baa0d5d8743153e244f0b4daec5e3 so 12.5 introduced the new way. The person who I was reporting it for probably reported the wrong server's chef version

chr4 commented 7 years ago

If removing the = adds compatibility for older chef-clients for free, while not hurting newer clients, I think merging this would be worth it.

chr4 commented 7 years ago

476871e1 was introducing this. @sspans, can you comment on this?

chr4 commented 7 years ago

After checking the chef-client source, this seems like a no brainer. Merging.

chr4 commented 7 years ago

Released in v2.3.1. Thanks again!

sspans commented 7 years ago

@andytson-inviqa thanks for catching that one!