search

chr4-cookbooks / iptables-ng

Cookbook to maintain iptables rules and policies on different platforms, respecting the way the os handles these settings.
GNU General Public License v3.0
38 stars 32 forks source link

Update cookbook for Chef 13+ #72

Closed infertux closed 6 years ago

infertux commented 6 years ago

See https://github.com/chr4-cookbooks/iptables-ng/issues/71

infertux commented 6 years ago

I ran bundle exec rake all with commit 8a1dc7ca25316526e517ed5ba48e6b79466b6d64 and all tests are passing (even though it took several hours to run them all). I'll test it in production now and report back...

infertux commented 6 years ago

@chr4 So I've been testing these changes on a few production machines and it's working fine so I guess it's good to merge if you're happy with it.

I also ran bundle exec rake all with Chef 13 (using https://github.com/chr4-cookbooks/iptables-ng/pull/72/commits/56e61b93dfa4432da0c1379ccbb655290ad95a5a) and all tests pass.

Note I bumped the major version from 3.x to 4.0.0 to respect semantic versioning since we now require Chef 13+ in metadata.rb.

chr4 commented 6 years ago

Thanks for the work you've put into this! I'll test this on a few machines myself and then merge it. Would you mind being added to the contributors list in the README? If so, just add yourself in the way you please (nickname, realname) - or let me know and I'll do it.

infertux commented 6 years ago

Cool, I added myself to the README. I've only tested it on Debian so it'd be great if you have other distros lying around :)

infertux commented 6 years ago

Hmm this new "suggestion feature" from GitHub is making a mess to the Git history. Let me squash those commits together...

chr4 commented 6 years ago

looks good to me! If there's nothing issing from your side, I'll merge this.

infertux commented 6 years ago

LGTM as well :)

chr4 commented 6 years ago

Released v4.0.0. Thanks again! Good job :)