search

chr4-cookbooks / newrelic-ng

Chef cookbook to install and configure different monitoring services for newrelic
19 stars 13 forks source link

newrelic-plugin-agent 1.3.0 use different executable name #25

Closed coltzhao closed 10 years ago

coltzhao commented 10 years ago

newrelic-plugin-agent 1.3.0 use different executable name

/usr/local/bin/newrelic-plugin-agent instead of /usr/local/bin/newrelic_plugin_agent

causing the startup script to fail.

chr4 commented 10 years ago

Hi, thanks for reporting!

Can you state which linux distribution you are using? I was experiencing different behaviour on various distributions when I was testing lately.

coltzhao commented 10 years ago

$ lsb_release -a No LSB modules are available. Distributor ID: Ubuntu Description: Ubuntu 12.04.2 LTS Release: 12.04 Codename: precise

chr4 commented 10 years ago

Thanks Sir!

I'm about to run the tests, bear with me for a while, I'll then release the fix.

chr4 commented 10 years ago

Mmh, I can reproduce your problem using some of my servers, although when running the tests in the kitchen boxes, the executeable is still called newrelic-plugin-agent (using Ubuntu 14.04, 13.10, 12.04)

JonasNielsen commented 10 years ago

The executable is also named newrelic-plugin-agent on my system.

$ lsb_release -a
No LSB modules are available.
Distributor ID: Ubuntu
Description:    Ubuntu 12.04.4 LTS
Release:    12.04
Codename:   precise
jeffbyrnes commented 10 years ago

@chr4 @JonasNielsen that's actually exactly what @coltzhao was saying; that the exec is named newrelic-plugin-agent now, instead of newrelic_plugin_agent. This is, in fact, a change that occurred. You can see this reflected on the other NR cookbook, at escapestudios-cookbooks/newrelic#90. You can see the actual change at MeetMe/newrelic-plugin-agent@95c07832e00ca0fe2914f3a42126683f0d645313.

chr4 commented 10 years ago

Current master branch should use newrelic-plugin-agent, but some tests still fail. Maybe setting action :upgrade here https://github.com/chr4-cookbooks/newrelic-ng/blob/master/recipes/plugin-agent-install.rb#L27 will help.

@coltzhao, can you try whether current master fixes your issue?

chr4 commented 10 years ago

This should be fixed in v0.5.0. Closing.