chr4 / nginx.vim

Improved nginx vim plugin (incl. syntax highlighting)
449 stars 41 forks source link

Add install guide for Vim 8+ #16

Closed hongquan closed 4 years ago

hongquan commented 4 years ago

Vim 8 with native plug-ins management feature has been released for a long time, but our guide is not updated to catch it.

chr4 commented 4 years ago

Hey, thanks for your pull request!

Mmh, I've not heard much about the new feature of vim, but it seems like it's rather opinionated. From what I've heard, it doesn't manage packages, it just loads them - leaving the user with updating each package by hand.

I'm also not a huge fan of git-submodules, as they've over and over created problems for me - although it seems to have gotten better lately.

Especially if the first point is true, and package management is not taken care of with vim 8, I'm not comfortable with recommending it to users (especially newbies). Furthermore, a lot of people these days use neovim, and I'd like to also be compatible with it.

alkurbatov commented 4 years ago

Hi @chr4 . Just wanted to mention that:

From what I've heard, it doesn't manage packages

It is how it works. Also, it doesn't generate help tags by default.

Furthermore, a lot of people these days use neovim, and I'd like to also be compatible with it.

I can confirm that this approach is fully compatible with Neovim as I use this great plugin exactly this way.

hongquan commented 4 years ago

From what I've heard, it doesn't manage packages, it just loads them - leaving the user with updating each package by hand.

I may wrong when calling that feature "package manager". But my point is that, Vim 8+ let you add a plugin without installing additional package manager.

Some people want to have a proper package manager, fine, but somebody only want to add plugin as quickly as possible. That is the method this PR mentions.

One use case is that I want to edit Nginx configuration on the server. It is the server so I don't plan to install a whole development suit with vim on it. I just need a hit-and-run way.

chr4 commented 4 years ago

Thanks for the feedback!

I can confirm that this approach is fully compatible with Neovim as I use this great plugin exactly this way.

That's good to know! I'll try it out someday.

I have no issues to mention this as a possibility to install the plugin, especially because there's not a section for doing this without a package manager, so I'm fully on board with that. The only thing I'm not sure about is the recommendation. Would it be an option for you to just add a section "manual" or "native" install, and adding it alongside the instructions for the different package managers @hongquan? Then it's neutral and people can decide for themselves which way they're most comfortable with.

hongquan commented 4 years ago

@chr4

I changed the wording, not to promote the "native" method over "package manager" methods.

chr4 commented 4 years ago

Perfect, thank you!