[Bug]: System button bar have white buttons over white background in player's view on older Android

[Porkepix]

Bug Summary

At least in player's view (didn't see in others, by I didn't try all the views), system buttons bar have white buttons over white background on older Android versions.

See this screenshot:

Screenshot


And for reference those similar issues: https://github.com/Livinglist/Hacki/issues/184 https://github.com/beemdevelopment/Aegis/issues/531 https://github.com/celzero/rethink-app/issues/802

Version

1.3.2

Steps to reproduce the bug

No response

Screenshots or Screen recordings

No response

Environment

Android Oreo (8.0), stock ROM

Other helpful information

No response

[Porkepix]

This is a actually a little bit stranger: the issue happen when going to the player's view from the main one or from Android's home. But if you lock the phone and unlock it, the color is fine. Same goes if you have the white view, and then it goes to the next track: now the issue isn't here.

Also, reporting here as it's probably completely related, see below a screenshot of the top system bar (with time, notifications and so on) which is a white strip, not even taking the whole width and impossible to read.

Screenshot


[chr56]

Well, actually we can not resolve this.

As we known:

1. Normally, Phonograph (Plus) use dark Navigation Bar / System Bar as usual, and these buttons use white color.
2. In some places (Main Player), the color of Navigation Bar / System Bar will dynamically change based on images palette/prominent color.

However, only after Android O (8.0), there are APIs provided by Android to change the color of Navigation Bar Buttons / System Bar Buttons color dynamically or programmatically. Before that, we can not change color of these buttons except hard-coding to theme resource.

Since the color of Navigation Bar / System Bar may be dark or light dynamically or randomly, and no way to change buttons or icons on it dynamically or programmatically before Android O, and we could not hard code these colors, nothing can be done so far.

[Porkepix]

Then maybe this dynamic change can be disabled on those older platforms? Because it currently is a usability issue with buttons pretty hard to see. Note that I just took a look and the dynamic change was disabled for me btw, so it shouldn't be affecting the bar at all and shouldn't be the cause of the reported issue.

This also showed me that the toggle button color have contrast issues on dark theme with default settings, see screenshot below.

Screenshot


[Porkepix]

Also note that I found another player (with a couple of problems of itself) that manage to change the color of this system bar depending on the cover dominant colors on that same phone. Dunno how they do it, though.