search

chr56 / Phonograph_Plus

A semi-active fork of kabouzeid/Phonograph -- a revived classic material designed music player for Android
GNU General Public License v3.0
392 stars 19 forks source link

[Bug]: issue of `mid` (MIDI) file format support #132

Open pixel2user opened 11 months ago

pixel2user commented 11 months ago

Bug Summary

Internal Error: error while reading the song file l9.a: No Reader associated with this extension:mid at d9.b.a(SourceFile:115) at player.phonograph.mechanism.tag.SongInfoReaderKt.loadSongInfo(SourceFile:31) at player.phonograph.ui.modules.tag.i1.invokeSuspend(Unknown Source:87) at w6.a.resumeWith(SourceFile:1) at n7.i0.run(SourceFile:1) at s7.h.run(SourceFile:1) at t7.k.run(SourceFile:1) at t7.a.run(SourceFile:63)

Version

1.3.2 (1032)

Steps to reproduce the bug

  1. Open Details for a midi file
  2. A error message is shown by the app in the notification list.

Screenshots or Screen recordings

No response

Environment

Package name: player.phonograph.plus App version: 1.3.2 (1032) Git Commit Hash: e5fd7bf0db27965a967f680490fbedd07dc23f60 Android version: 12 (SDK 32) Device brand: google (by Google)

Other helpful information

No response

chr56 commented 11 months ago

Well, you can see this because currently it is not supported to read mid/midi files' tags or matadata.

Since it is not a popular or "regular" file format, there is no plan to support reading it for now.

pixel2user commented 11 months ago

@chr56 - Why not change the behaviour to not trying to read tags or metadata of not supported media files that play just well? These kind of error messages should only be seen if a kind of debugging mode is activated.

No need to support the reading of the tags or metadata, but the error messages are a bad user experience, because the audio is player without problems.