chr56 / Phonograph_Plus

A fork of kabouzeid/Phonograph in maintenance and development
GNU General Public License v3.0
371 stars 19 forks source link

[Bug] Tag editor causes the app to crash or freeze when too many items are being edited #203

Open nishkaamprem opened 1 month ago

nishkaamprem commented 1 month ago

Crash log

No crash log appears

Version

1.8.0 d6bf4b15

Steps to reproduce the bug

  1. open the app
  2. Go to albums
  3. Select 10 or more items or a playlists
  4. open them in a tag editor

Sometimes the app just freezes and crashes when you open the tag editor and other times when you try to save changes

Environment

Android version 14 Samsung Galaxy A04e

Screenshots or Screen recordings

This is what happens when the app freezes up Imagepipe_21

Other helpful information

Not sure this only happens with alot of items in the tag editor. I got it to save the changes once after 10 tries in an album with 7 or so songs.

So, after some testing even if i dont respond to the close app prompt, the app will crash and go back to a fresh start and it will also crash all the other background processes and refreshes all the other apps

just like @LostExcalibur im having this problem with only opus files

chr56 commented 1 month ago

Sorry, I could not reproduce it. Maybe this is device specified. And it would be better if you have crash log when available. I could not fix or even investigate any bug without enough information collected. Sorry!

nishkaamprem commented 1 month ago

Sorry, I could not reproduce it. Maybe this is device specified. And it would be better if you have crash log when available. I could not fix or even investigate any bug without enough information collected. Sorry!

@chr56 I have edited the issue and added some more information pls check it out and see.

nishkaamprem commented 1 month ago

@chr56 So, after some testing even if i dont respond to the close app prompt, the app will crash and go back to a fresh start and it will also crash all the other background processes and refreshes all the other apps

LostExcalibur commented 1 month ago

I am experiencing the same issue, the application basically lags out and crashes anytime I enter the tag editor. This happens on all my music files, which have been downloaded with yt-dlp (relevant flags are --embed-metadata --embed-thumbnail) and stored in opus format. It does not happen on other songs, so I presume the issue lies with some tag that yt-dlp adds.

Here is the environment information :

App version:     1.8.1 (1081)
Git Commit Hash: 1956a97a5c4760f3e7dacbc7fe828a784a941575
Package name:    player.phonograph.plus
Release favor:   modernStable
Android version: 13 (API 33)
Architecture:    arm64-v8a, armeabi-v7a, armeabi
Soc:             SM8350/lahaina (by Qualcomm) 
Device brand:    OnePlus (by OnePlus)
Device model:    OnePlus9Pro_IND/LE2121 (code OnePlus9Pro)
Build version:   LE2121_13.1.0.593(EX01)
                 (R.159cc68-4eae-182baf)
Language:        fr
Screen:          3032x1440 (dpi 560)
Permissions:     Storage(READ WRITE)

I can provide some files to reproduce if needed.

Edit : after looking a little closer, I have some m4a files downloaded the same way, which pose no issue. I guess it has to be with the way tags are embedded in opus files.

nishkaamprem commented 2 days ago

I am experiencing the same issue, the application basically lags out and crashes anytime I enter the tag editor. This happens on all my music files, which have been downloaded with yt-dlp (relevant flags are --embed-metadata --embed-thumbnail) and stored in opus format. It does not happen on other songs, so I presume the issue lies with some tag that yt-dlp adds.

Here is the environment information :

App version:     1.8.1 (1081)
Git Commit Hash: 1956a97a5c4760f3e7dacbc7fe828a784a941575
Package name:    player.phonograph.plus
Release favor:   modernStable
Android version: 13 (API 33)
Architecture:    arm64-v8a, armeabi-v7a, armeabi
Soc:             SM8350/lahaina (by Qualcomm) 
Device brand:    OnePlus (by OnePlus)
Device model:    OnePlus9Pro_IND/LE2121 (code OnePlus9Pro)
Build version:   LE2121_13.1.0.593(EX01)
                 (R.159cc68-4eae-182baf)
Language:        fr
Screen:          3032x1440 (dpi 560)
Permissions:     Storage(READ WRITE)

I can provide some files to reproduce if needed.

Edit : after looking a little closer, I have some m4a files downloaded the same way, which pose no issue. I guess it has to be with the way tags are embedded in opus files.

@LostExcalibur Can you provide the files for some testing?

My opus files were downloaded using newpipe, im guessing it also adds some tags to the opus files.