search

chr5tphr / zennit

Zennit is a high-level framework in Python using PyTorch for explaining/exploring neural networks using attribution methods like LRP.
Other
200 stars 32 forks source link

Composite: bug in BetaSmooth constructor? #172

Closed annahdo closed 1 year ago

annahdo commented 2 years ago

Hi,

I noticed that the beta_smooth parameter is not passed to the ReLUBetaSmooth hook when initializing the BetaSmooth composite in composites.py. This results in the default use of beta_smooth=10 at all times. I assume that's not intended, or am I missing sth?

Best

chr5tphr commented 2 years ago

Hey @annahdo

good catch, that's indeed not intended, thank you for the issue! Would you like to open a Pull Request for the fix yourself, where the parameter is correctly passed?

annahdo commented 2 years ago

sure, I'll do that.

chr5tphr commented 1 year ago

Done in #173