chr5tphr / zennit

Zennit is a high-level framework in Python using PyTorch for explaining/exploring neural networks using attribution methods like LRP.
Other
183 stars 33 forks source link

ValueError message in AlphaBeta rule #199

Closed jackmcrider closed 11 months ago

jackmcrider commented 11 months ago

For alpha < 0 or beta < 0, AlphaBeta rule raises a Value error with the message:

Both alpha and beta parameters must be positive!

where in fact one value can be zero. Actually, the documentation explicitly mentions (alpha=0, beta=1.0).

chr5tphr commented 11 months ago

Agreed, thanks for spotting and fixing this!