search

chris-barry / darkweb-everywhere

HTTPS Everywhere rulesets for hidden services and eepsites.
http://onion.im
Other
167 stars 32 forks source link

Case sensitive issue on Macs #22

Closed thoughtless closed 10 years ago

thoughtless commented 10 years ago

The default Mac OS X filesystem is (somewhat) case insensitive. This project contains several files that only require case sensitivity to make the filenames unique. When trying to install on a mac, you'll only get one of the two "duplicated" files.

src/chrome/content/rules/DuckDuckGo.xml
src/chrome/content/rules/NewsBlur.xml
src/chrome/content/rules/ThePirateBay.xml
src/chrome/content/rules/Tor2Web.xml

This is easy to see if you clone the project on a Mac. You'll immediately see local, unstaged changes. In theory this could be easily fixed by simply renaming one of the two files. But I suspect that only one copy of each should be kept. I'm just not sure which one is the correct one. Perhaps they need to be merged.

I'm also seeing a "new" file created:

cert-validity/mozilla/builtin-certs/NetLock_Arany_=Class_Gold=_Fo\314\213tanu\314\201si\314\201tva\314\201ny.crt

I suspect it is caused by the non-ASCII characters.

colinmahns commented 10 years ago

Hey thoughtless, welcome to the project :)

I had no idea OS X was affected by case sensitivity like Windows was. I am not exactly a consistent OS X user, despite owning a Mac.

The duplicate errors are a result of both the original HTTPS Everywhere rules and our own rules co-mingling in the same folder. I believe Chris and I have discussed prepending our rule names with onion or eepsite, which would alleviate this problem.

As for that "new" file, where did you see that being generated? I sadly don't have access to a machine (virtual or physical) with OS X for the next couple of days so I can't exactly reproduce your steps at the moment.

colinmahns commented 10 years ago

Chris should've fixed this issue with his latest commit. I'm going to test it in a little bit just to make sure.

colinmahns commented 10 years ago

Okay, can confirm that the case-sensitive issues aren't present anymore inside my case-sensitive OS VM. Closing.