Closed jutozex closed 10 years ago
Please dont merge yet
Unless there is some cache in my browser or OS now some rulesets work but some doesnt. I guess its about my removal of target host *.onion codes. But why some works while some does not? For example whonix ruleset works for me while autistici doesnt
Well, if that code is necessary, at least for some rulesets you can ignore my last 2 commits. The first 2 commits should be working fine
Finally got a chance to test out your code. I'm not too sure what you mean in your second post as to which sites aren't working. Can you get a little more specific? I tested both examples you mentioned, along with every other rule that was modified that defaults to being active, and I haven't run into any of the issues you specified.
I'd say this patch is OK to be merged @chris-barry.
Ok I think this patch is good but I think there is still something wrong because on Tor Browser under Whonix (maybe debian or linux) the autistici ruleset doesnt redirect, it is not shown in the HTTPS Everywhere button too (but it is on the list). But on Tor Browser under Windows every ruleset seems to work. Hope you can reproduce this
That's really strange. I'm spinning up Whonix now to see if I can reproduce this problem.
Thanks for the update.
There indeed seems to be a bug, though I dont know the reason.
When I update the name as simple as
<ruleset name="Aaaaa">
the redirection works. When I revert back the name it doesnt
Was able reproduced your problem, however, using the inventati.org domain, I was able to be redirected to the hidden service. I looked into the preferences pane for HTTPS Everywhere inside Whonix, I think that since the two .xml files for Autistici and Inventati are named the same, one might be conflicting with the other. I think if we combine the two files, both domains should work again.
Since the name change -not the file name- fixed this for me, this should probably be reported to https-everywhere.
Because at the same time, everything same, there's no problem on Windows
Are you able to get to inventati.org on Windows? I just tried on Tor Browser Bundle on my local machine and it seems like Autistici works, but not Inventati. Strange.
Ok good, I didn't know about the inventati.xml file, it shows that you should not use the same name for different rulesets. Under Whonix, the inventati.xml seems to have the priority while on Windows it is autistici.org.
I pushed the fix, ready to merge.
Optimized codes in all rulesets.
Added ddg.gg and dgg.gg to duckduckgo.
Fixed tor2web which wasnt working.
Redirecting all thepiratebay.* and www.thepiratebay.* domains to hidden service except two domains. Also added a list of other proxies for redirection.