search

chris-belcher / electrum-personal-server

Maximally lightweight electrum server for a single user
MIT License
600 stars 109 forks source link

Remove unused private key cracking functions #276

Closed theStack closed 2 years ago

theStack commented 2 years ago

The function crack_bip32_privkey was introduced in the first commit (probably copied over from pybitcoinlib), but was never used, i.e. it can be removed. The PR also removes the function subtract_privkeys which was only used in the cracking function. To my understanding, EPS in general shouldn't need to do anything with private keys.

chris-belcher commented 2 years ago

Almost the whole of the pybitcointools library can be deleted. Nobody should use it, it's a pretty bad library. The only thing it has going for it is that it doesn't have any other dependencies. But thanks for this, a small part of the job of eventually deleting most of the library.

Back at the start of EPS it was used a lot more, then after the use of descriptors/deriveaddresses was added the library was used much less. I think now it's only used for Old Mnemonic wallet (with electrum_pubkey), encoding and decoding the bip32 xpub prefixes, and maybe some data parsing functions in peertopeer.py.