search

chris-billingham / battle_of_the_bands

A repository containing the code that generated my Battle of the Bands - Starring Tidytext and Tensorflow presentation
3 stars 0 forks source link

genius_album does indeed provide album name :) #1

Open JosiahParry opened 4 years ago

JosiahParry commented 4 years ago

Hey Chris, first off, awesome slides! If the talk is recorded I'd love to see it.

Referencing your somewhat hilarious comment https://github.com/chris-billingham/battle_of_the_bands/blob/34fa2fa586c542b2c6ed23c36d78b88e3cdf848c/01_get-radiohead-lyrics.R#L20, I wanted to let you know that you totally can get the album name returned from genius_album() you just the info argument to info = "all". If you can create an issue that would be great. If you want to take a stab at changing the default arg that would be very much appreciated!

as an addendum, given your workflow I think Chapter 5.1 or mirr might be a good reference in the future.

If you run into any other bugs, please lemme know!

chris-billingham commented 4 years ago

Hey @JosiahParry

Thanks so much for getting in touch. Glad you liked the slides. Love the genius package, thanks for all the work in it.

Great to hear I don't have to run that little func to get the album name returned, it'll be good to get my code updated for that. TBH It's all getting a bit smelly as it's a flat transfer from a previous repo which is almost 18 months old now! However happy to muck in and look at changing the default arg. Keep an eye out for a PR.

Thanks for the link to Tidy MIR, I'll be sure to give it a read. Interestingly the idea around genre using LDA has got me thinking about using the stm package on this (which nicely has a "guess the value of k" property). Thoughts for a future piece of work...

Thanks, Chris