search

chris-chris / pysc2-examples

StarCraft II - pysc2 Deep Reinforcement Learning Examples
Apache License 2.0
753 stars 356 forks source link

Errors after baselines repo latest commit #12

Open arturdulewicz opened 6 years ago

arturdulewicz commented 6 years ago

After cleanups done in baselines repo I am getting new errors while running train_mineral_shards (with enjoy_mineral_shards everything works just fine)

Traceback (most recent call last):
  File "C:/Users/Artur/Documents/PySC2/train/train_mineral_shards.py", line 14, in <module>
    from a2c.policies import CnnPolicy
  File "C:\Users\Artur\Documents\PySC2\train\a2c\policies.py", line 3, in <module>
    from baselines.acktr.utils import conv, fc, dense, conv_to_fc, sample, kl_div
ImportError: cannot import name 'conv'

Process finished with exit code 1

Any help?

rwill128 commented 6 years ago

I'm encountering the same issue, no progress yet.

brean commented 6 years ago

Same here. Seems baselines changed their API. conv now only has dense and kl_div (see current utils.py and this commit where it was deleted ). I think baselines.a2c.utils conv can be used from there instead because it seems to be a duplicate. But I am not so sure for all the other functions because fc has less lines of code and their parameter are named different for example. I think we should open an issue in the baselines-github issue tracker.