search

chris-hld / spaudiopy

Spatial Audio Python Package
https://spaudiopy.readthedocs.io/
MIT License
138 stars 13 forks source link

Spherical Hankel function #6

Closed egerdem closed 4 years ago

egerdem commented 4 years ago

In "mode strength" function :

def spherical_h2(n, z): with np.errstate(divide='ignore'): return scyspecial.spherical_jn(n, z) + 1j * scyspecial.spherical_yn(n, z)

Shouldn't it be minus sign ? return scyspecial.spherical_jn(n, z) - 1j * scyspecial.spherical_yn(n, z)

https://spaudiopy.readthedocs.io/en/latest/_modules/spaudiopy/sph.html#mode_strength

chris-hld commented 4 years ago

Oh thank you! Yes that is correct! I accidentally implemented the spherical hankel function of the first kind , rather than of the second kind. In this particular case it shouldn't cause problems, but I will correct and extend this.

chris-hld commented 4 years ago

Fixed in d53f8e66a3b9121937d8ee92b8156c1d521db877

egerdem commented 4 years ago

Oh I see, thanks :)

Chris Hold notifications@github.com, 19 Ara 2019 Per, 12:37 tarihinde şunu yazdı:

Oh thank you! Yes that is correct! I accidentally implemented the spherical hankel function of the first kind http://mathworld.wolfram.com/SphericalHankelFunctionoftheFirstKind.html, rather then of the second kind http://mathworld.wolfram.com/SphericalHankelFunctionoftheSecondKind.html . In this particular case it shouldn't cause problems, but I will correct and extend this.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/chris-hld/spaudiopy/issues/6?email_source=notifications&email_token=AIJO62RUTYGYJCBI6EANH33QZM6E3A5CNFSM4JYGLJP2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEHJANZA#issuecomment-567412452, or unsubscribe https://github.com/notifications/unsubscribe-auth/AIJO62T4K2DL6WTJCKJ5VWDQZM6E3ANCNFSM4JYGLJPQ .