Open didactic-drunk opened 4 years ago
How would you like to handle conflicts between System::User/Group
and Crystal's?
Did they FINALLY add something? I am a little afraid to look...
Yes. It's a class
instead of struct
.
home
vs home_directory
.
name
and username
clash. Crystal uses name
for the gecos field.
Maybe keep uid
/gid
and let crystal have it's own String
id methods?
# The user's username.
getter username : String
# The user's identifier.
getter id : String
# The user's primary group identifier.
getter group_id : String
# The user's real or full name.
getter name : String
# The user's home directory.
getter home_directory : String
# The user's login shell.
getter shell : String
My suggestion:
home
.username
vs name
. I'd say do it crystal's way and provide a warning somewhere.uid
/gid
methods.Thank you for adding me as a collaborator. I know it can be frustrating having all your work thrown out.
If you have feedback to avoid breaking your code I'm all ears.
If I don't hear from I'll:
README.md
.Your proposal sounds fine. I would err on the side of aliasing so that existing code doesn't break (Does crystal have an attribute to mark something as deprecated?).
Feel free to email me (in my profile). I tend to prefer private communication and I regularly check it.
Your proposal sounds fine. I would err on the side of aliasing so that existing code doesn't break (Does crystal have an attribute to mark something as deprecated?).
Yes. Deprecated aliasing will be used for home
and anything else not kept.
name
and username
clash. Crystal uses name
for the gecos field. This shard uses it for the username. Deprecation can't solve this issue. I think they only way forward is release a new version letting crystal manage name
, bump the major version and hope it doesn't cause conflicts in anyones code.
WIP. Specs pass but a real program doesn't compile.