Make pureline shellcheck compliant

chris-marsh / pureline

A Pure Bash Powerline PS1 Command Prompt

MIT License

507 stars 95 forks source link

Make pureline shellcheck compliant #47

Closed LiteracyFanatic closed 3 years ago

LiteracyFanatic commented 4 years ago

Fix a number of issues related to globbing, word splitting, local declarations, and logical operators. This fixes at least one real bug where tr will fail if more than one file named 's', 'p', 'a', 'c', or 'e' exist in the current directory.

popup-ch commented 3 years ago

I was about to propose a fix for just the tr -d '[:space:]' bug, but this is much neater.

chris-marsh commented 3 years ago

Thanks for the fixes and apologies for taking so long to merge!

LiteracyFanatic commented 3 years ago

No problem; life gets busy sometimes. Thanks for merging.