We are trying out the new version of your classifier. I am wondering if you'd consider this modification, which updates findThresh() to return a list of results, instead of globally assigning variables? I also updated your README to reflect this new pattern. return() is a bit cleaner.
The ultimate reason for this (and I'd be happy to do another PR with this code), if that I wrote a function to encapsulate one round of calling, such that we can perform multiple rounds easily, approximately like:
Hello,
We are trying out the new version of your classifier. I am wondering if you'd consider this modification, which updates findThresh() to return a list of results, instead of globally assigning variables? I also updated your README to reflect this new pattern. return() is a bit cleaner.
The ultimate reason for this (and I'd be happy to do another PR with this code), if that I wrote a function to encapsulate one round of calling, such that we can perform multiple rounds easily, approximately like:
r1 <- performRoundOfMultiSeqCalling(bar.table.full, 1) neg.cells <- c(neg.cells, r1$neg.cells) final.calls <- r1$final.calls
r2 <- performRoundOfMultiSeqCalling(r1$bar.table, 2) neg.cells <- c(neg.cells, r2$neg.cells) final.calls <- r2$final.calls
r3 <- performRoundOfMultiSeqCalling(r2$bar.table, 3) neg.cells <- c(neg.cells, r3$neg.cells) final.calls <- r3$final.calls