search

chris-morgan / rust-http

Completely OBSOLETE Rust HTTP library (server and client)
Other
390 stars 110 forks source link

Fixed some warnings and deprecations #152

Closed reem closed 10 years ago

reem commented 10 years ago

Not sure what to do about the dead_code warning for ValueToken, should that be used?

chris-morgan commented 10 years ago

The slicing_syntax feature is required at present and can’t be removed.

reem commented 10 years ago

Bizarre. This builds for me without errors.

reem commented 10 years ago

Hmm... The error is a linker error form rust-openssl. This is also weird, because that error doesn't show up on my machine. It's possible that it is OS dependent. Regardless we don't need slicing_syntax.

chris-morgan commented 10 years ago

It didn’t need slicing_syntax in a build from two days ago, but four hours ago I made a new build and it started requiring slicing_syntax. (That’s why I just added it.)

reem commented 10 years ago

Oh joy. Let me rebase this PR to remove that change then.

reem commented 10 years ago

Actually, is it possible we could wait for this to hit nightlies first? Having this change already means all my builds + local examples and such are broken until it hits nightlies.

chris-morgan commented 10 years ago

As you may have observed, I’m very relaxed about all these sorts of things. Whenever and however you feel like doing it!

chris-morgan commented 10 years ago

Or you could #![allow(unknown_features)].

reem commented 10 years ago

I'll just wait till tomorrow. Not going to do much more tonight anyway.

reem commented 10 years ago

This got fixed in another PR, closing.