search

chris-mosley / AmazonBrandFilter

Filters Amazon search results to only be "known" brands.
MIT License
44 stars 5 forks source link

Missing `brands.txt` #3

Closed kevinkhill closed 10 months ago

kevinkhill commented 10 months ago

Can I ask why was this removed? I was looking around on how to add to the list.

I cloned your repo and installed it to test. How did that 👇 that line work when you removed brands.txt?

https://github.com/chris-mosley/AmazonBrandFilter/blob/6f434c9b2c1f73326e92ada2b5a8091110b58377/background.js#L32

chris-mosley commented 10 months ago

Sorry to clarify. Are you wondering where the data is stored after it's downloaded? Or are you having trouble hitting that URL?

It might be the same between this one and the other issue created for version. Those are stored in the browser storage here:

https://github.com/chris-mosley/AmazonBrandFilter/blob/6f434c9b2c1f73326e92ada2b5a8091110b58377/background.js#L19C30-L19C31

and here:

https://github.com/chris-mosley/AmazonBrandFilter/blob/6f434c9b2c1f73326e92ada2b5a8091110b58377/background.js#L40

chris-mosley commented 10 months ago

Ohhh. I think I know what's happening here.

The list is in a separate Repo here:

https://github.com/chris-mosley/AmazonBrandFilterList

I did this to decouple the list from the addon itself. So that I could push list version updates without having to update the add-on itself.

Does that help?

kevinkhill commented 10 months ago

Yes.... suddenly my eyes could see List all over and I realized it wasn't all in one place....

I appreciate your patience as I stumble around your project 🤣