Fix storage default values so that all required StorageSettings keys are set

chris-mosley / AmazonBrandFilter

Filters Amazon search results to only be "known" brands.

MIT License

44 stars 5 forks source link

Fix storage default values so that all required StorageSettings keys are set #37

Closed barrymun closed 11 months ago

barrymun commented 11 months ago

add default values when setting storage (do not include brandsMap when setting sync storage as chrome will complain)
check that all storage values have a default for runs that are not the first run for backwards compatibility
do not overwrite settings for runs that are not the first run if the settings already exist
some refactoring like function and variable name changes

barrymun commented 11 months ago

@chris-mosley i think these changes should fix the issue with the personal block list. it seems as though we were not setting all of the keys in storage on first run, even though the StorageSettings interface indicated that these values should exist even though they may be undefined. i've tested on chrome and firefox and everything seems to be working. if there are still problems with firefox i'll need additional information, thanks