Local storage values should always be set when sync storage values are set by the user in the popup

chris-mosley / AmazonBrandFilter

Filters Amazon search results to only be "known" brands.

MIT License

44 stars 5 forks source link

Local storage values should always be set when sync storage values are set by the user in the popup #46

Closed barrymun closed 10 months ago

barrymun commented 10 months ago

changes:

reformat the manifest files to remove duplicated keys
clean up the popup logic so that is less verbose
ensure that the settings are changed in both sync and local storage when the user alters the popup settings. setting the values in local handles cases whereby the sync storage cannot be set (e.g., for unauthenticated chrome users)

barrymun commented 10 months ago

@chris-mosley this one should fix the popup settings not being persisted in sync storage. i've cleaned up the base manifest.json logic too so that there are less duplicates (meaning we don't have to remember to update the code in more than 1 place when necessary)