search

chris-ritsen / network-audio-controller

Control Audinate Dante network audio devices without Dante Controller
The Unlicense
192 stars 21 forks source link

SIGPIPE unavailable on Windows10/11 : catch exception ? #17

Open rem5 opened 5 months ago

rem5 commented 5 months ago

Hi,

EDIT: not seen previous open issue related to it: https://github.com/chris-ritsen/network-audio-controller/issues/9

netaudio device list gives me error on Windows 11: site-packages\netaudio\console\application.py", line 1, in <module> from signal import signal, SIGPIPE, SIG_DFL ImportError: cannot import name 'SIGPIPE' from 'signal' (C:\Program Files\Python312\Lib\signal.py). Did you mean: 'SIGFPE'?

Seen there: https://stackoverflow.com/questions/58718659/cannot-import-name-sigpipe-from-signal-in-windows-10

Replacing this solved in https://github.com/chris-ritsen/network-audio-controller/blob/master/netaudio/console/application.py the problem for me:

try:
    from signal import signal, SIGPIPE, SIG_DFL
    signal(SIGPIPE, SIG_DFL)
except ImportError:  # If SIGPIPE is not available (win32),
    pass             # we don't have to do anything to ignore it.

But don't know if it's the best solution.

Mo-way commented 1 week ago

@rem5 Could you test the PR on your end please?